[fix](fe) Reject multi-column NGRAM_BF indexes#64343
Merged
Merged
Conversation
### What problem does this PR solve?
Issue Number: DORIS-19296
Problem Summary: Creating an NGRAM_BF index with multiple columns passed FE validation and could reach BE tablet creation, where tablet metadata expects each NGRAM_BF index to bind exactly one column. This rejects invalid DDL during FE analysis for both inline table indexes and CREATE INDEX.
### Release note
Reject invalid multi-column NGRAM_BF index definitions during DDL analysis.
### Check List (For Author)
- Test: Unit Test / Build
- ./run-fe-ut.sh --run org.apache.doris.nereids.trees.plans.commands.IndexDefinitionTest
- ./build.sh --fe
- Added regression coverage under index_p0; not run locally because no worktree Doris cluster was started.
- Behavior changed: Yes. Invalid multi-column NGRAM_BF index definitions now fail in FE analysis.
- Does this need documentation: No
airborne12
requested review from
924060929,
englefly,
morrySnow and
starocean999
as code owners
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
Author
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
TPC-H: Total hot run time: 29324 ms |
Contributor
TPC-DS: Total hot run time: 169439 ms |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Member
Author
|
run buildall |
Contributor
TPC-H: Total hot run time: 29625 ms |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
TPC-DS: Total hot run time: 169362 ms |
Contributor
TPC-H: Total hot run time: 29258 ms |
Contributor
TPC-DS: Total hot run time: 168815 ms |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Member
Author
|
/review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Review result: no blocking issues found.
Critical checkpoint conclusions:
- Goal and proof: The PR rejects multi-column NGRAM_BF definitions in
IndexDefinition.validate(), which is reached by inline table indexes,ALTER TABLE ADD INDEX, and standaloneCREATE INDEX. The new unit and regression cases cover the invalid multi-column DDLs, and the build-index unit case covers the deferred path where columns are intentionally absent. - Scope: The code change is small and focused on the existing single-column validation branch, with no unrelated behavior changes.
- Concurrency/lifecycle: No new concurrency is introduced. The non-intuitive lifecycle is the deferred
BUILD INDEXconstructor withcols == null; the added early return for NGRAM_BF preserves that path. - Config/compatibility/protocol: No new configuration, storage format, or FE-BE protocol fields are added.
- Parallel paths: Nereids parser paths for inline indexes, alter add index, and create index all construct the same
IndexDefinition; build index is handled separately by the deferred branch. - Conditional checks: The new condition aligns NGRAM_BF with existing single-column index types while exempting deferred build validation.
- Tests/results: Added FE unit coverage and regression negative cases. No
.outupdate is needed because the regression additions are exception-only. - Observability, transaction/persistence, performance: Not applicable for this validation-only change; no issue found.
- User focus: No additional review focus was provided.
I attempted to run ./run-fe-ut.sh --run org.apache.doris.nereids.trees.plans.commands.IndexDefinitionTest, but the runner failed during generated-code setup before executing tests because thirdparty/installed/bin/protoc is missing.
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
morrySnow
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Related PR: None
Problem Summary:
Creating an NGRAM_BF index with multiple columns passed FE validation and could reach BE tablet creation, where tablet metadata expects each NGRAM_BF index to bind exactly one column. This rejects invalid multi-column NGRAM_BF definitions during FE analysis for both inline table indexes and CREATE INDEX.
Release note
Reject invalid multi-column NGRAM_BF index definitions during DDL analysis.
Check List (For Author)
Test
regression-test/suites/index_p0/test_ngram_bloomfilter_index.groovyfor inline table index and CREATE INDEX paths. Not run locally because no worktree Doris cluster was started../run-fe-ut.sh --run org.apache.doris.nereids.trees.plans.commands.IndexDefinitionTest./build.sh --feBehavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)